Skip to content
OverviewSolutions
1
Comments
2
Alex Salgado
@alexgsalg

All comments

  • Nikola•30
    @Nikola-MiticSubmitted about 2 years ago

    What did I do right or wrong?

    What did I write that was unecessary and what didn't I write that was necessary?

    Solution to QR code excercise

    2
    Alex Salgado•50
    @alexgsalgPosted about 2 years ago

    Hey Nikola, Just some quick tips that I noticed, but overall you did a nice job.

    • One thing is the scale was a little bigger compared with the design provided but with the right proportions;
    • You styled the body with margin: 2rem; and height: 100vh; which creates a scroll on the screen, margins are spaces outside the block, in this case, use padding instead
    • Just an opinion: all the structure styles(display, justify-content...) you placed on the Body you could have placed on the <main> tag.
    • Last one, on the card the border-radius could be a little higher to match the design.
    Marked as helpful
    1
  • Alex Salgado•50
    @alexgsalgPosted about 2 years ago

    Hey, First of all, good job on being careful with proportions.

    I think just like me you forgot to apply the drop-shadow on the card rs. One thing I noticed is the size of the lower description text block is a little wider than the image, a little more padding could do the trick.

    Just an idea to keep in mind, you could have added the "attributes" part on the bottom with absolute position, almost sure that would make the card align perfectly with the mock design.

    cheers

    Marked as helpful
    1