Skip to content
OverviewSolutions
4
Comments
4
Xavier192
@Xavier192

All comments

  • Dimas Abiyoga•140
    @d-abiyogaSubmitted about 3 years ago

    Hello everyone, I just finished this challenge by using ReactJS. If you have any suggestion how I should better implement React hooks (useState and useEffect), form validation, or anything else to improve my code, I would appreciate it.

    Thank you.

    Tip Calculator App with ReactJS

    1
    Xavier192•110
    @Xavier192Posted about 3 years ago

    Haia, it looks great! Well done. I have some suggestions though (I don't know react):

    • Limit your input range.
    • Center the card.
    • Comment your code by blocs.
    • Erase custom tip when click on a button.
    • Use alt attribute on images.

    Greetings ^-^ !

    Marked as helpful
    0
  • EVargas714•50
    @EVargas714Submitted about 3 years ago

    I learned a lot doing this project. Thinking of re-doing it to fully grasp everything I learned. I have 2 questions though.

    1. Is there any way to change the footer logo to green using CSS only? The alternative graphic wasn't included so I'm assuming there is an alternate solution.

    2. For blank DIVS with backgrounds, what Aria landmark do I use?

    Sunnyside Agency Landing Page using HTML, CSS and JS

    2
    Xavier192•110
    @Xavier192Posted about 3 years ago

    Helpful, thank you!

    0
  • Sophie•60
    @sophieQuinSubmitted about 3 years ago

    Hi there,

    I have done it ! I am quite happy with myself to actually finish the challenge.

    This was my very first DOM Manipulation challenge, so it really took me a while to get there.

    This was a great challenge and really tested my knowledge on some area. So a lot of reading was involved.

    Although, I couldn't quite figure out why I need to include document method such as "let myBill = document.........value" inside my function on not just apply a variable name to it and just use that variable in my function. It seemed to only accept it that way ?

    Thank you for any feedback you would give me, I appreciate your effort !

    Sophie

    Tip Calculator App

    2
    Xavier192•110
    @Xavier192Posted about 3 years ago

    Hi, first up, it looks great, and sorry about my english. I have some advice (I can be wrong):

    • Try to use <header> <main> <section> landmarks in contact with body for html5 standards.
    • When you want to change the css using javascript apply classes or ids to html, don't use the style property (encapsulation).
    • Don't use globals in javascript, they can be accessed from other javascript files and rewritten, use the Module Pattern.
    • Put script tag in head you can use defer attribute.
    • Try to use *{} selector for css reset or use normalize.css.
    • Try to use mobile first approach for css (You can use desktop first but I personally prefer mobile first).
    • Limit the input numbers in a range 0-999999 for example.
    • Center the card you can use flex, grid, or transform.
    • Use a css methodology, BEM is good.

    PD: document.something references your HTML document, So you select something from your html document.

    Marked as helpful
    0
  • Xavier192•110
    @Xavier192Posted about 3 years ago

    Okay, Thank you for your adive, I'll do it. :)

    0