Skip to content
OverviewSolutions
11
Comments
3
Wadie Ben
@WadieBenabdouh

All comments

  • Wadie Ben•200
    @WadieBenabdouhPosted about 2 years ago

    Well done!

    0
  • Joyce•70
    @joyce-souzaSubmitted about 2 years ago

    This is my solution to the qr code component challenge. Is it ok to use REM for width and height? I made it this way for the design to be larger or smaller depending on the font size chosen by the user. I also didn't put media query, because the size is already good on the phone, in my opinion. Any feedback is welcome! :)

    Update 10/26: I've made some code improvements. I removed the picture tag, added a heading, improved the box-shadow and alt attribute, changed the image's border-radius, made the container's padding-bottom larger and now I use REM for fonts only.

    QR code component using flexbox

    2
    Wadie Ben•200
    @WadieBenabdouhPosted about 2 years ago

    Great solution Joyce, usually REM units are primarily used for fonts size so I wouldn't recommend using it on layouts, alternatively you can absolutely use EM and percentage% units.

    And EXCELLENT work.

    Marked as helpful
    0
  • Wadie Ben•200
    @WadieBenabdouhPosted about 2 years ago

    Hi dude, so I see you didn't properly align the container which has the heading, sub-heading and the stats, the only solution to align them properly is by adding some padding to the container also for the items they should be in a flexbox container with "justify-content: flex-start;"

    feel free to check my CSS code > https://github.com/WadieBenabdouh/stats-card/blob/master/style.css

    Marked as helpful
    1