Erlando
@TheRealByteraverAll comments
- @Ejdam090Submitted about 2 years ago@TheRealByteraverPosted about 2 years ago
Cool design, it differs from the frontendmentor one but I suppose that was intentional. The mobile design is not finished I suppose? It did not work for me. Also, one small detail you might want to fix is that the number resulting of an operation can overflow the display. I solved this by using scientific notation. Good job overall +1
0 - @jgreen721Submitted about 2 years ago
Mumbled at the calculator logic a bit more than I was anticipating. Still some bugs with the Delete button but for the most part it works. Wouldn't do my taxes using it though. lol
@TheRealByteraverPosted about 2 years agoThe design is beautiful, I like the glowing buttons :) I noticed however that the theme selector doesn't work in the desktop version and that the colors are a bit off for the secondary themes, but I suppose you're aware of that. As with some other implementations, it is possible to type "outside" of the dialog containing the result of the mathematical operation, you might want to fix that ;) Nice work, keep it up +1
Marked as helpful1 - @ele-darSubmitted about 2 years ago@TheRealByteraverPosted about 2 years ago
Cool and pretty design that also works well on mobile! The calculator works well, I noticed two issues though:
- the user is able to enter numbers that are "longer" than the input field
- any operation following the result of a previous multiplication or division seems to yield "infinity" So a cool result I'd say, just two minor issues to look through maybe, if you are interested in that aspect of the challenge of course.
0 - @MaliklarSubmitted about 2 years ago@TheRealByteraverPosted about 2 years ago
Nice design, very close to the original. I like how you insert comma's in big numbers for easier reading. I noticed that dividing a very big nr like 10000000000 by 10 for example does not yield a correct result though. Also, the way the operator changes after you entered the second operand (e.g. 2+2x8 becomes 2x28) is a bit counterintuitive in the beginning maybe. The mobile design seems a bit too tall, too.(I personally tried to solve this without using media queries but couldn't in the end ;)) I like how the theme transition is animated. Cool implementation, Congratulations!
0