Skip to content
OverviewSolutions
8
Comments
5
Semandr
@Semandr

All comments

  • Haider Fadel•360
    @z3sbSubmitted over 2 years ago

    if you have any advice for me, i will be so happy

    #css Flex

    1
    Semandr•170
    @SemandrPosted over 2 years ago

    Some hover effect for buttons may be very useful. End fix issues of course...

    Marked as helpful
    0
  • Iva•120
    @IvuskaSubmitted over 2 years ago

    Great challenge for CSS Grid practice. I discovered grid-template areas that made the code much easier (from my point of view at least).

    I also continued with SASS partials.

    I would be grateful for any comments to my code and how can I improve my grid/sass parts. Could I make it somehow more readable than it is?

    Thank you.

    Four card feature session (CSS Grid, SASS, mobile first solution)

    1
    Semandr•170
    @SemandrPosted over 2 years ago

    Sorry for mi English, first of all... What I see....

    • No classes for all tags
    • .json for this simple project?
    • What about fonts??
    • Where is the mobile version? I'm newbie too, but... why upload unfinished challenge?
    0
  • Semandr•170
    @SemandrPosted over 2 years ago

    Hello! To avoid this problem, you need to use "input" tag, like this: <input type="radio"> <input> elements of type radio are generally used in radio groups—collections of radio buttons describing a set of related options.

    Only one radio button in a given group can be selected at the same time. Radio buttons are typically rendered as small circles, which are filled or highlighted when selected.

    Marked as helpful
    1
  • Semandr•170
    @SemandrPosted over 2 years ago

    Perhaps adding a smooth transition on hover with the mouse would be nice... Many html elements are missing classes. As for the JavaScript code, the same task can be solved in many ways, the main thing is what works :)

    Marked as helpful
    1
  • derrick•30
    @derrick-itSubmitted almost 3 years ago

    Hello 🖖,

    My naming sense and css writing style is still messy. I would love to have opinions on that !

    Made with HTML and SCSS

    2
    Semandr•170
    @SemandrPosted almost 3 years ago

    Hi. Try to read this about BEM: https://en.bem.info/methodology/quick-start/

    Marked as helpful
    1