All comments

• 

  Neil Khatri•620

  @nkhatri7Submitted almost 3 years ago

  Any feedback is really appreciated :)

  

  Mobile first REST countries API built with React Router and SCSS

  3

  40
  

  Sandeep Gumaste•365

  @SandeepGumastePosted almost 3 years ago

  0 accessibility and html issues. Great work! Mine has a ton of accessibility issues that I need to fix.

  0

  This comment has received 1 replyShow
• 

  Mari•555

  @ChurrinChurronSubmitted over 3 years ago

  I even put a notice that you have already sent the mail well with a div, although, I feel that the javascript code is somewhat repetitive, but at least it works. Also, no matter how much I put 100vh for the background, it doesn't want to cover the screen.

  If you know how to facilitate that, it would help me a lot.

  

  HTML5, CSS3, Javascript

  1

  10
  

  Sandeep Gumaste•365

  @SandeepGumastePosted over 3 years ago

  try using background-size: cover

  2
• 

  nmorajda•945

  @nmorajdaSubmitted over 3 years ago

  Any feedback on what could be improved is welcome!

  

  Mobile first site using FlexBox, Sass and BEM

  1

  11
  

  Sandeep Gumaste•365

  @SandeepGumastePosted over 3 years ago

  I liked the fixed navbar and 'to the top' button. Very cool!

  0
• 

  Sandeep Gumaste•365

  @SandeepGumasteSubmitted over 3 years ago

  This was my first Junior level challenge. Used AOS library to add some cool animations. Can someone please check and let me know how I can improve it further?

  

  Landing page using HTML CSS and JS

  1

  10
  

  Sandeep Gumaste•365

  @SandeepGumastePosted over 3 years ago

  Ooops!!! Whole page isn't showing because I added some animations from the Animate on scroll library.

  0

  This comment has received 3 repliesShow
• 

  Yash kharat•20

  @Yashkharat28Submitted over 3 years ago

  Suggest some easy and simple way to do it.

  

  3-column preview card component

  1

  20
  

  Sandeep Gumaste•365

  @SandeepGumastePosted over 3 years ago

  Instead of using padding on the body, you could've given appropriate width to the container div and centered it using flexbox.

  0

  This comment has received 1 replyShow
• 

  Marlon Passos•940

  @MarlonPassos-gitSubmitted over 3 years ago

  When placing the element I had to use some "magic numbers" in the margin of my elements to make those spaces in the user part. Is there a cleaner way to do this without having to put infinite DIVs in the code?

  I also tried using BEM to organize my classes in CSS but I don't know if how I used it was too much

  

  Static page make with flexbox

  3

  30
  

  Sandeep Gumaste•365

  @SandeepGumastePosted over 3 years ago

  You could use "justify-content: center" in the card-profile div.

  1

  This comment has received 1 replyShow
• 

  Maja•55

  @majxlaSubmitted over 3 years ago

  I am a beginner so I would appreciate any tips. My solution is based on grid and I had a problem to center the columns on the page. I will still practice this in other challenges.

  Edit: I did it a second time. This time I used Flexbox instead of Grid. Thanks guys for your help :)

  

  3-column preview card component solution

  2

  10
  

  Sandeep Gumaste•365

  @SandeepGumastePosted over 3 years ago

  You could have made 3 columns of 1fr each or Flexbox approach would have been better.

  Marked as helpful

  0