Skip to content
OverviewSolutions
4
Comments
2
Rami Hegazy
@Rami-Hegazy

All comments

  • Orlando Verdin•330
    @OrlilandSubmitted 9 months ago

    Hi! This is the first version of my project, I only implemented the visual design, in the next version, I want to implement JSON content and DOM manipulation

    Result summary component

    2
    Rami Hegazy•60
    @Rami-HegazyPosted 9 months ago

    Very Great design and also an organized code. Do you want to be friends, I feel like you could teach some helpful stuff and also I can tell you what I know , It would be great to make some friends that help along with the coding journey :)

    1
  • Rami Hegazy•60
    @Rami-HegazyPosted 10 months ago

    Hey Sandeep, There are some improvements to your code that I would consider:

    1-Avoid Inline Styles: Move styles from inline HTML attributes to CSS for better separation of concerns.

    2-Use IDs Sparingly: Consider using classes instead of IDs for styling elements, especially when styles are shared among multiple elements.

    3-Avoid Overly Specific Selectors: Use more general selectors to prevent specificity issues and make the CSS easier to maintain.(no need for doing #smaller1, #smaller2,#smaller3)

    4-Semantic HTML: Ensure the HTML structure is semantic and appropriately represents the content. Avoid using that many divs as specially if they are empty.

    5-Use CSS Flexbox or Grid: Simplify layout positioning by using CSS Flexbox or Grid instead of absolute positioning where possible. Also never use <br> or   to space your html elemnents, It should be done in CSS.

    Hope you find this Helpful, Please mark it as helpful if it was :)

    Marked as helpful
    0