@Saf-AwiSubmitted over 1 year ago
PRIYANSHU SAHANI
@PriyanshuSahaniAll comments
- @PriyanshuSahaniPosted over 1 year ago
Great job on the challenge, it is an extensive design
There are some fine tweaks you can make to improve user experience:
- The paragraph text on New section is hard to read. Setting it to off white will make it pop out a bit more.
- Align the website logo with the nav links. You can do so by clubbing them in a flex container and set
align-items: center
. In your case doing that on the header element should do.
Marked as helpful0 - @thenewusSubmitted over 1 year ago
practicing grid
@PriyanshuSahaniPosted over 1 year ago- Excellent on desktop
- However your design isn't responsive on mobile view. Try adding that using media queries in your CSS. It's pretty simple. You just have to set the grid container to have only one column if the viewport width is less than a certain value, say 500px.
0 - @sanjaykrishnanDEVSubmitted over 1 year ago
HTML CSS
Thanks to the project have learnt a couple of new things like CSS Grids!
@PriyanshuSahaniPosted over 1 year agoLooks nice overall
Though you can make some tweaks to enhance your design
These might help:
-
Center your container on the viewport: You can do so by making body a flex container and
align-items: center
, you will have to fix body height at 100vh for it to work. -
The font size on username is too big and its ruining the alignment of the profile photo too... you might wannna reduce that down
Marked as helpful0 -