Skip to content
OverviewSolutions
19
Comments
3
Phoenix243
@PhoenixMputu

All comments

  • Phoenix243•310
    @PhoenixMputuPosted about 2 years ago

    Sorry if my English is not correct, I am French -speaking. Very good solutions, but your solution is a bit minimalist. You have positioned your card very well in the center but there is not the mobile version. I don't know if you didn't do it because you don't think it was important or because you used Grid and it complicated you to adapt it to mobile. If this is the case you could use Flexbox.

    Marked as helpful
    0
  • Phoenix243•310
    @PhoenixMputuPosted about 2 years ago

    Sorry if my English is not correct, I am French -speaking. Very good solutions, but the mobile version is not centered. In the mobile version you did not resize your columns and positions your cards to be centered. You were satisfied with a margin: Auto, which is not a good idea. You could also make it simple with the flexbox. And also uses sematic tags and the BEM convention.

    Marked as helpful
    0
  • Phoenix243•310
    @PhoenixMputuPosted about 2 years ago

    First excuse for my English. I am Francophone. Bravo for the will and the courage that you have. First, you should first read the style-guide file of the challenge and apply what is given. You should name your classes according to the BEM standard. I think you know the flexbox pretty well. And finally you have to use the appropriate tags. But keep practicing, you're on the right path

    0