Skip to content
OverviewSolutions
4
Comments
3
Nikhil Reddy
@NikhilReddyManda

All comments

  • Nikhil Reddy•100
    @NikhilReddyMandaPosted over 1 year ago

    Hey there 👋 Congrats on completing the project.

    Suggestions to improve it:

    1. Change the background color of the body. You can find in the style-guide.md file.
    2. Import Fonts. You can find in the style-guide.md file.
    3. Change the colors of the text.
    4. Add a shadow at the bottom of the box.

    Hope this helps✨. Happy Coding😀

    0
  • Nikhil Reddy•100
    @NikhilReddyMandaPosted over 1 year ago

    Hey there 👋. Your projects look great! I have a few suggestions though:

    1. Decrease the width of the image.
    2. Decrease the width of the text conatiner.
    3. Picture Tag 📷

    • Looks like you're currently using single image for both Desktop & Mobile devices, but we want to swap images according to their screen sizes. Luckily there's a native html element which may help us to achieve this method without need of css

    • So let me introduce the picture element.

    • The <picture> tag is commonly used for responsive images, where different image sources are provided for different screen sizes and devices, and for art direction, where different images are used for different contexts or layouts. Example:

    <picture>
<source media="(max-width: 768px)" srcset="small-image.jpg">
<source media="(min-width: 769px)" srcset="large-image.jpg">
<img src="fallback-image.jpg" alt="Example image">
</picture>

    • In this example, the <picture> tag contains three child elements: two <source> elements and an <img> element. The <source> elements specifies different image sources and the conditions under which they should be used.

    • Using this approach allows you to provide different images for different screen sizes without relying on CSS, and it also helps to improve page load times by reducing the size of the images that are served to the user.

    Happy Coding! 😀

    Marked as helpful
    1
  • Nikhil Reddy•100
    @NikhilReddyMandaPosted over 1 year ago

    Hey there 👋. Your project looks great! I have a few suggestions though

    1. Change the colors of your text. If you observe the solution, heading text is in a bluish color and the description is in greyish color.
    2. Make your card component little bit bigger then it will perfectly match the solution.
    3. I recommend increasing the font size of the heading to make it look similar to the solution.

    Hope this helps ✨. Happy coding

    Marked as helpful
    1