Skip to content
OverviewSolutions
13
Comments
10
mohammad
@Mohammd1321

All comments

  • vernerk•75
    @vernerkSubmitted over 3 years ago

    Hello! Here is my third submission on the frontendmentor.io platform. Still love the css animations as you can tell :D

    Also this time I approached the coding of the project as mobile first. I must tell that it saved me a lot of headache and I had to write much less code.

    Although on a landingpage like that, most likely a client does not want to present ratings that are given less than 5 stars, but I added a possibility to add every rating from one to five. These classes can be added easily with JS to the span element. For example if there is a 4 star rating you can add a class .four-stars to the span element and it will present 4 stars instead of 5.

    As always, feel free to comment :) Awesome, awesome platform and community here!

    Cheers, Verner

    HTML, CSS

    3
    mohammad•305
    @Mohammd1321Posted over 3 years ago

    hey man your layout awesome but i noticed you included every element literally to give them the same style there is something called universal selector which is this * instead of writing every single element in there like you did here

    html, body, div, span, applet, object, iframe, h1, h2, h3, h4, h5, h6, p, blockquote, pre, a, abbr, acronym, address, big, cite, code, del, dfn, em, img, ins, kbd, q, s, samp, small, strike, strong, sub, sup, tt, var, b, u, i, center, dl, dt, dd, ol, ul, li, fieldset, form, label, legend, table, caption, tbody, tfoot, thead, tr, th, td, article, aside, canvas, details, embed, figure, figcaption, footer, header, hgroup, menu, nav, output, ruby, section, summary, time, mark, audio, video you can replace all of that with simply this

    • {

    }

    1
  • mohammad•305
    @Mohammd1321Posted over 3 years ago

    awesome i liked it soo cool just like thu said just the problem in email input other than that everything is looking great :)

    0
  • mohammad•305
    @Mohammd1321Posted over 3 years ago

    liked it mate good job!!

    0
  • mohammad•305
    @Mohammd1321Posted over 3 years ago
    1. hey man so you can use background-image and play with the background-position of it
    2. or you can make it an absolute image for the container and use top right bottom left to set it position just keep on mind using position % is different than using it with px or rems / ems have fun :)
    1
  • mohammad•305
    @Mohammd1321Posted over 3 years ago

    hey man i suggest you use grid-template-areas for this one if you want or you can use grid-template-columns (4,1fr) and then start spanning the cards

    0
  • Jude Miracle•135
    @am-miracleSubmitted over 3 years ago

    please i really need feedback i looks different from my pc screen and the live site i don't know what caused #codenewbie

    flexbox

    2
    mohammad•305
    @Mohammd1321Posted over 3 years ago

    its looking very good man dw it looks fine in small screens goodjob bro :)

    0
  • mohammad•305
    @Mohammd1321Posted over 3 years ago

    hey man everything looks awesome but its not responsive which is a big downside so you need to look at that and knowing that you are new to HTML and css that looks very good goodjob man keep it going 🤩

    1
  • mohammad•305
    @Mohammd1321Posted over 3 years ago

    awesome man but the two buttons down there don't really work for some reason

    0
  • mohammad•305
    @Mohammd1321Submitted over 3 years ago

    I LEGIT hate myself i tried to do a second scroll bar for the overlay i did not know how its the only thing that broke my layout 😭😭i want an idea in how to fix it

    flexbox grid scss

    3
    mohammad•305
    @Mohammd1321Posted over 3 years ago

    thank you all for the support i think I fixed everything now

    0
  • mohammad•305
    @Mohammd1321Submitted over 3 years ago

    I LEGIT hate myself i tried to do a second scroll bar for the overlay i did not know how its the only thing that broke my layout 😭😭i want an idea in how to fix it

    flexbox grid scss

    3
    mohammad•305
    @Mohammd1321Posted over 3 years ago

    iam about to break the whole thing down I am soo madd omg

    0