Skip to content
OverviewSolutions
1
Comments
3
Miran Firdausi
@Miran-Firdausi

All comments

  • Miran Firdausi•55
    @Miran-FirdausiPosted almost 4 years ago

    Nice Work,

    But you should have the font weight of the top heading a little less. and the color of the second and third boxes are interchanged.

    BTW Rest of the work is Good.

    1
  • Miran Firdausi•55
    @Miran-FirdausiPosted almost 4 years ago
    1. There are no Background Images in your page.
    2. Your code on Github is private so I can not see your code.
    3. Dimension of the objects are little different.
    4. Also Your Page is Not Mobile-friendly.

    There were few Background Images given in the images folder, check that out and add both images in the background: One of the method is using CSS to add multiple images in the background by separating URL's by commas(,).

    eg: body {background-image: url('images/filename.svg'), url('images/filename.svg') and add the remaining attributes to make it more accurate.}

    You also have to write the attribute for both of the images separated by commas.

    You can make the repository of your Github to public (if you wish)so that others can see your code and suggest you.

    The margins and padding are more than required.

    By the way rest of your code looks Perfect.

    Happy Coding.

    1
  • Michał•45
    @MiLabudaSubmitted almost 4 years ago
    • I have had problems with adding patterns. I tried to add them via :before and :after on class .container but it didn't get the results
    • I don't know if I were using BEM methodology correctly

    BEM

    1
    Miran Firdausi•55
    @Miran-FirdausiPosted almost 4 years ago

    Your Code has few error:

    First, For the images used in the DIV: Use Code: {background-image: url('images/bg-pattern-card.svg'); --->remove '/' before images.

    For the Background Image you can directly add those two circles without using DIV tag: Use Code: body { background-image: url('images/filename.svg'), url('images/filename2.svg');}

    This way you can add two or more background images together by adding commas for multiple file location. Also use attribute in CSS with this (if you want) like: {background-repeat: no-repeat, no-repeat; background-position-y: -450px, 350px; background-position-x: -30%, 123%; background-size: 60%, 60%; background-attachment: fixed, fixed;}

    Separate the values of both images with commas in every attribute. In this way you can add multiple images in the background with background color.

    Check and edit all your URL's remove slashes, BTW rest of your code looks fine. There are several ways to make same thing, everyone is different. If you want to follow your own method you can. Also you can check other people's post to see how they made it.

    Happy coding.

    1