Skip to content
OverviewSolutions
8
Comments
3
Lisa Clark
@Lisa-C-27

All comments

  • Lisa Clark•185
    @Lisa-C-27Posted about 3 years ago

    Hi Albert, I think the issue might be when you are adding a to-do item you don't check if dark-theme is active, and then if it is active add the dark-items class on the new to-do that is being created. Another alternative would be to not have the class dark-items at all and just utilise the overarching dark-theme class to add the styles to the required components instead.

    Marked as helpful
    0
  • Lisa Clark•185
    @Lisa-C-27Posted over 3 years ago

    I think you have done a pretty good job for a beginner. My only suggestions would be instead of putting width of 375px on the cards and the main element I would put max-width instead as on a smaller phones of screen width up to 375px it is too wide and then also add some padding on the main so that there is some space between the edge of the screen and the cards. And very nice job on matching the design.

    Marked as helpful
    1
  • Lisa Clark•185
    @Lisa-C-27Posted over 3 years ago

    Hi, I noticed your border-radius isn't correct for mobile, which you would need to add those border-radius dimensions to your media queries and then change the initial border-radius for those cards. A suggestion would be instead of putting the border-radius on the individual cards would be to put border-radius on the outer container (.main) with overflow: hidden, then you wouldn't need to add any media queries for it.

    Another suggestion would be to put a max-width on the outer container (.main) so that at larger screen sizes it doesn't stretch.

    Other than that, I think you have done a good job matching the design.

    Marked as helpful
    0