Skip to content
OverviewSolutions
7
Comments
4
Lawrence
@LawrencePryer

All comments

  • Mark Sainsbury•45
    @Sa1nersSubmitted almost 4 years ago

    My second challenge, so all feedback welcome. I was not happy with the position of the images within the four boxes but could not find a better way to adjust their position within the individual divs. Any suggestions greatly recieved.

    Four Card Feature Section using HTML & CSS

    2
    Lawrence•240
    @LawrencePryerPosted almost 4 years ago

    Hi Mark

    Great work and looks very close to me! As you mentioned, the position of the icons is maybe the one obvious difference.

    I just had a go at this challenge myself and managed to position the icons by using absolute positioning. There may be better ways but this seemed to work for me.

    For your .box class try setting the position: relative and then give your icons a class and set these to position: absolute. You can then try something like bottom: 30px and right: 30px to get them exactly where you want them.

    I hope that helps. Keep up the good work!

    Lawrence

    1
  • Abdurshd•10
    @inSgit3Submitted almost 4 years ago

    I've seen the style recommendation after finishing the work, so for the 1st time let it be like this. This is not responsive for mobile use yet. If you have any feedback, you are welcome

    A page with Html and css

    1
    Lawrence•240
    @LawrencePryerPosted almost 4 years ago

    Hi Abdurshd.

    This looks great and very close to the original. The main difference is between the stats (followers, likes, photos) section at the bottom. I think some margins would help to space them out better.

    Look forward to seeing more of your designs.

    0
  • Lawrence•240
    @LawrencePryerPosted almost 4 years ago

    Hi Sagar

    This looks great! I am currently struggling through this same challenge myself so it is interesting to see how you did this. My one suggestion would be regarding your variables for CSS. Rather than naming the variables after the actual colours (e.g. --dark-magenta) , I understand it is good practice to call them things like "color-primary" and "color-secondary". This way if a company decides to change the colour scheme in the future, you don't have to change the variable names. For example if the company decided to change from a dark magenta to a dark orange, you would need to go through and change all your variables throughout the code, rather than just the colour codes in the :root section.

    I hope that helps and makes sense. Hopefully somebody more experienced can confirm whether my suggestion is a good one or not.

    2
  • Cartxu•65
    @cartxuSubmitted almost 4 years ago

    Hello there! :) This is my first challenge here, and I am barely new at this, so any feedback is more than welcome! Thank you so much!!

    HTML and CSS

    2
    Lawrence•240
    @LawrencePryerPosted almost 4 years ago

    Hi Catxu. Looks great! I've also started having a go at this project as I'm new to HTML and CSS, too.

    The only suggestion I can make is for your buttons. It might be better if the active state is set to outline: 0 (if this doesn't work, maybe try outline: none). I think this should get rid of the black box around the buttons when you click and hold on them.

    Good luck with your studies!

    1