Skip to content
OverviewSolutions
7
Comments
2
Jimmy D.
@Jd536

All comments

  • Kirsten ✨•460
    @ofthewildfireSubmitted over 2 years ago

    Hello, this is my first challenge on here, and truthfully it took me a bit to complete!

    In terms of feedback, I was wondering if anyone would let me know if there are any "no-no"s I committed (was my code written to the standard it should have been) with my HTML (was it not semantic, etc.) - I tried my best to use <divs> in the right spot, I do believe I used both a class and an ID when I believe I could have just used one of them.

    Yeah! Apologies for it being super ugly and super messy. :( and thanks in advance to anyone who answers my question, I appreciate it.

    QR Code Component Using HTML & CSS

    2
    Jimmy D.•160
    @Jd536Posted over 2 years ago

    Hey Kirsten,

    Great start! ✨

    The Background-colors match the design

    Here are a few things you could improve:

    1. Make sure the font-family match the Design. The style-guide file suggested Outfit Get Started with the Google Fonts API

    2. Set the font size to 15px (no big deal, but it's always best to follow design recommendation).

    3. Instead of using div around main class, you could use main for accessibility purposes.

    4. The last thing and the most important is that your solution is not responsive. The QR-code is not visible on mobile. Kindly update your code to match the mobile design. 🙂 Resource.Responsive design

    I hope this is helpful. Feel welcome to let me know if you have any questions.

    Have an excellent weekend. ☕

    Marked as helpful
    1
  • Jimmy D.•160
    @Jd536Posted over 2 years ago

    Hey @rendaardy

    Awesome Job! Way to go.

    Here are a few things I would improve.

    #Color matching.- The main container color on your solution is #252e37 while the deign is #1f2630 To match design colors if not specified, I have been using the Firefox Eyedropper function available on the Firefox browser console.

    https://firefox-source-docs.mozilla.org/devtools-user/eyedropper/index.html

    It would also be awesome if you could add a few pixels to the height of the main box to match the design.

    So far, that's all I could see. I hope this is helpful.

    Great Job ✨

    0