All comments

• 

  David Alejandro Cuastumal Bucheli•100

  @DcuastumalSubmitted over 2 years ago

  I would like to be able to receive criticism that will help me improve my code and be able to have a better performance.

  

  Profile Card Component

  2

  80
  

  Ukwueze Harrison Chukwuebuka•20

  @HalezisPosted over 2 years ago

  Hey, David. Big ups for completing this project. I was just working on it, but couldn't find my way around making the top and bottom background look like in the design. So your solution came just at the right time, helped me complete it. Also loved the life you gave it using JavaScript.

  Cheers. Happy coding!

  Marked as helpful

  0

  This comment has received 1 replyShow
• 

  Leonard Appelgryn•320

  @KaptainCS3Submitted over 2 years ago

  Resubmitted design, count on your feedback

  

  flexbox and scss

  1

  60
  

  Ukwueze Harrison Chukwuebuka•20

  @HalezisPosted over 2 years ago

  Hey, Leonard. Great work you've done here.

  But if you noticed, the button disrupts the size of the container while hovered, this is as a result of the extra (1px solid) you added to the .btn: hover element in line 147.

  I faced a similar issue while I tried this challenge, and this is how I think you should go about it.

  ​.​btn​:​hover​ { 
   ​  ​color​:​ ​#​f2f2f2​; 
   ​  ​background​:​ none; 
   ​  ​border​:​ ​1​px​ solid; 
   ​  padding​:​ ​9​px​ ​0​;
   ​} 
  

  Notice I added same padding as in your .btn then subtracted 1px to account for the solid border. I hope this helps. Happy coding

  1

  This comment has received 3 repliesShow