Skip to content
OverviewSolutions
9
Comments
8
Erik Tangvik
@Etang131

All comments

  • JP Yepez•55
    @jpyepezSubmitted almost 4 years ago

    Hi all,

    Jumping back into front-end after a brief break. I gave this one a shot with only HTML, CSS and JS. I'd appreciate any feedback. Thanks!

    HTML, CSS and JS only

    2
    Erik Tangvik•255
    @Etang131Posted almost 4 years ago

    To fix the background image on the thumb you might want to use: background-image: url("/images/icon-slider.svg"); background-repeat: no-repeat; background-position: center; background-size: auto;

    Also how did you get your slider to change colors?

    1
  • Erik Tangvik•255
    @Etang131Posted almost 4 years ago

    It looks like it matches the spec to me. I would consider making the media query change happen a bit later from mobile to desktop though.

    0
  • Erik Tangvik•255
    @Etang131Posted almost 4 years ago

    The biggest issue is that if you don't submit an email address your code doesn't allow for the user to change that. Other than that it's pretty close to the design.

    0
  • Erik Tangvik•255
    @Etang131Posted almost 4 years ago

    It's really close to the design. On the Why us section I would space those out a tad more. Also I think the font weight is a bit different.

    0
  • Erik Tangvik•255
    @Etang131Posted almost 4 years ago

    Great job on your first project.

    1
  • Erik Tangvik•255
    @Etang131Posted about 4 years ago

    Your information bar looks better than the design. However I would make the search bar and search bar font a bit bigger.

    0
  • Erik Tangvik•255
    @Etang131Posted about 4 years ago

    I think the only thing is the font weight that is off. Everything else looks like it's correct in desktop mode.

    1
  • Erik Tangvik•255
    @Etang131Posted about 4 years ago

    You need to make the width quite a bit smaller. Also add a <br> tag after the word reviews and set it as display none in mobile.

    0