How can I minimize the code, or is it perfect?
CLRwebs
@CLRwebsAll comments
- @talhawebguruSubmitted almost 2 years ago@CLRwebsPosted almost 2 years ago
Hey, Your solution looks pretty good. You asked about the "code minimizing" , you have some rows what is unnecessary. For example on .qrCode you wrote the margin twice, you can also delete the empty rows on your HTML and CSS file. I don't really use 'px' for margin and padding , but It's really up to you. Other then that you made a good solution. Keep up the good work!
0 - @HILA94Submitted almost 2 years ago
Hi, I would like some feedback on this project :) especially with this two queries:
- how do i put the second price (169$) in the middle?
- how do i define a different image to shown only on mobile?
@CLRwebsPosted almost 2 years agoHey hila, You can put the new and the old price within the same <div>, and then you can do : display: flex; align-items: center;
For the mobile version (and on the desktop version too) you can make a <div> for it and set it as a background. I hope I helped you a little bit, have fun with your codes!
Marked as helpful0