All comments

• 

  Cesar Valencia•310

  @cvalencia1991Submitted almost 2 years ago

  Do you have any questions about best practices?

  

  Preview Card Component

  3

  30
  

  Aayush Kumar•110

  @AK-CHP1Posted almost 2 years ago

  Hi @cvalencia1991! Congratulations on completing this project. I think you can further improve the typography of your paragraph by adding line-height: 1.5. Also consider using CSS grids to properly leave gaps around your cards. Your .stylenumber element also seems larger than the card's heading, consider making it quite smaller.

  Rest looks great!

  Marked as helpful

  0

  This comment has received 1 replyShow
• 

  Gobinath•140

  @gopinath-97Submitted about 2 years ago

  Hi there all, made a basic card which looks good to me, if anyone finds any mistakes , bugs or code improv , let me know.

  

  Product Card

  3

  30
  

  Aayush Kumar•110

  @AK-CHP1Posted about 2 years ago

  Congratulations on completing this project

  Your solution looks good. But I think you can further improve this solution by;

  • Adding a line-height of 1.5 to your paragraphs
  • Using flexbox in your .content element for proper alignment and spacing of different components.

  Happy coding!

  0
• 

  TEKE•10

  @Teke111Submitted about 2 years ago

  I could not use flex box in my project because I do not really understand it. Does anyone have recommendations of where I can learn flexbox from?

  

  QR scan page using semantic HTML5 markup and CSS properties

  2

  40
  

  Aayush Kumar•110

  @AK-CHP1Posted about 2 years ago

  Congratulations on completing this project

  I think you can further improve your project by using media queries to change layout for mobile devices (max-width: 375px as per the style guide)

  Also you can learn the basics of flexbox at:

  • MDN here
  • Wes Bos's free course at flexbox.io

  Please consider checking my solution here and provide some feedback.

  Please let me know it that helped.

  Thanks

  0

  This comment has received 1 replyShow
• 

  Élder Ramos•30

  @elder-ramosSubmitted about 2 years ago

  

  QR Code Component

  2

  30
  

  Aayush Kumar•110

  @AK-CHP1Posted about 2 years ago

  Congratulations on completing the project

  I think the project would look better if you vertically center the .card section element. You can do that either by playing with margin values or using something like flexbox or positions (margin: auto doesn't help in centering vertically, you could instead use margin: <some value> auto ) . Also consider setting font-size of p element to 15px (as mentioned in the style guide), because it seems too small and almost becomes unreadable on small viewport. You should also use media queries to make some changes with the card for mobile layout.

  All the best. Please consider checking my solution of this problem here

  Any feedback and suggestions on how I can improve are very welcome!

  Marked as helpful

  1