@gbuckets30Submitted almost 4 years ago
I have used a lot of raw measurements in the project which I am sure will not scale on other devices. Please advice how I can avoid this in the future.
Miguel Dominguez
@0wlofminervaAll comments
- @0wlofminervaPosted almost 4 years ago
The style-guide attached provides the necessary information to establish the weight font and colors, don´t forget to aply it to the little details of the desing when you check it, ... congrats!
1 - @NismaELagderSubmitted almost 4 years ago
It is a pleasure to tell me your notes, so I can improve my coding skills
@0wlofminervaPosted almost 4 years agoThe typography doesn't match, and you are missing the spaces of the footer card components, ... and don´t forget on the html issues, ... congrats!
0 - @DplusKSubmitted almost 4 years ago
Has anyone tried tailwind in a project before, somehow when I am creating custom value on the 'tailwind.config.js' the default value doesn't work, for example I created 'circle' for height, using 'h-circle' then somehow 'h-full' or 'h-screen' doesn't work, similar thing happen with bg, I did have the purge on the config so I don't know if that's the thing that did it.
Also what actually is the benefit of using tailwind. Yes this project is not meant for using that but when dealing with repetitive styles its kinda annoying to keep making them, well I suppose I could have just used a loop for the data input, but still curious of what people think of tailwind.
Thanks for reading and sorry for rambling
@0wlofminervaPosted almost 4 years agothe heading and the names of the white cards are over-enhanced, it might be a grey color instead. The quote symbol doesn´t match with the original, and counting on the accessibility html issues, but overall its achieved, under my humble poiint of view. congrats!
1 - @gbuckets30Submitted almost 4 years ago
I have used a lot of raw measurements in the project which I am sure will not scale on other devices. Please advice how I can avoid this in the future.
@0wlofminervaPosted almost 4 years agoUtkarsh Saxena, you are missing the typography weight and color hyerarchy, aswell as the line dimness of the body card separation; the border-radious is a really pronounced in comparation with the original design, the layout settlement of the card and the background seems ok to me, though
0
